Conversation
b63d540 to
a9c420a
Compare
ca3b0ce to
886e029
Compare
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
…he oauth one Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
…rom nextcloud/.github Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
886e029 to
9f9b46e
Compare
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
9f9b46e to
5631c35
Compare
oleksandr-nc
approved these changes
Mar 15, 2026
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
5130efc to
6aee41a
Compare
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
6aee41a to
07a7f7b
Compare
Contributor
|
Unfortunetly, I can't test this, as tests are not working for my account( It will look like this: $twoFactorForm = GitHubHtml::findTwoFactorForm($selector);
if ($twoFactorForm === null) {
// WebAuthn/passkey page may be shown instead of TOTP, navigate to TOTP alternative
$totpPage = $this->navigateToTotpPage($currentUrl, $currentBody);
$currentUrl = $totpPage['url'];
$currentBody = $totpPage['body'];
['selector' => $selector, 'title' => $title] = $this->getPageContext($currentBody);
$twoFactorForm = GitHubHtml::findTwoFactorForm($selector);
if ($twoFactorForm === null) {
$this->fail('Could not find the GitHub 2FA form after navigating away from WebAuthn page. Page title: ' . $title . '. URL: ' . $currentUrl);
}
} |
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Member
Author
Sure go ahead, as long as you don't break it with the user used in the CI runs, all good 😁 |
Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>
Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>
Contributor
|
From my POV - this HUGE PR is READY |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/nextcloud/server/issues/1#issuecomment-1), the reference object contained an invalid value for the comment which resulted in a crash of the widget. That's solved by acting like it's just an issue/pr link when the comment was not found.